improve git prompt info in zsh yet again

Simplify to a single loop. Lots of sed's is bad. I'm sure I notice a speed
difference :D

zsh/omz-custom/cinaeco.zsh-theme

@@ -1,6 +1,5 @@
 ## Set tab title to hostname
 print -Pn "\e]1;`hostname | cut -d. -f1`\a"
-
 ## multi line prompt
 PROMPT='
 %{$fg[cyan]%}[%m]  %{$fg[yellow]%}%3~  $(git_prompt_info)
@@ -13,16 +12,15 @@ ZSH_THEME_GIT_PROMPT_PREFIX="[git:"
 ZSH_THEME_GIT_PROMPT_SUFFIX="]%{$reset_color%}"
 ZSH_THEME_GIT_PROMPT_CLEAN="%{$fg[green]%}"
 ZSH_THEME_GIT_PROMPT_DIRTY="%{$fg[blue]%}"
-ZSH_THEME_GIT_PROMPT_UNMERGED="%{$FG[160]%}u"
-ZSH_THEME_GIT_PROMPT_UNTRACKED="%{$FG[244]%}?"
-ZSH_THEME_GIT_INDEX_MODIFIED="%{$FG[076]%}+"
-ZSH_THEME_GIT_INDEX_ADDED="%{$FG[076]%}+"
-ZSH_THEME_GIT_INDEX_DELETED="%{$FG[076]%}x"
-ZSH_THEME_GIT_INDEX_RENAMED="%{$FG[076]%}>"
-ZSH_THEME_GIT_INDEX_COPIED="%{$FG[076]%}c"
+ZSH_THEME_GIT_PROMPT_UNMERGED="%{$FG[226]%}U"
+ZSH_THEME_GIT_PROMPT_UNTRACKED="%{$FG[220]%}?"
 ZSH_THEME_GIT_TREE_MODIFIED="%{$FG[124]%}+"
 ZSH_THEME_GIT_TREE_DELETED="%{$FG[124]%}x"
-
+ZSH_THEME_GIT_INDEX_MODIFIED="%{$FG[070]%}+"
+ZSH_THEME_GIT_INDEX_ADDED="%{$FG[070]%}+"
+ZSH_THEME_GIT_INDEX_DELETED="%{$FG[070]%}x"
+ZSH_THEME_GIT_INDEX_RENAMED="%{$FG[070]%}r"
+ZSH_THEME_GIT_INDEX_COPIED="%{$FG[070]%}c"
 
 ##############################
 # FUNCTIONS
@@ -30,7 +28,8 @@ ZSH_THEME_GIT_TREE_DELETED="%{$FG[124]%}x"
 
 ## Override the default `git_prompt_info` function
 ## We decide if we show nothing, status with no branch (like in submodules) or
-## with a branch using regex comparisons. Is there a better way?
+## with a branch using regex comparisons.
+## Is there a better way than relying on error output?
 function git_prompt_info() {
   ref=$(git symbolic-ref HEAD 2>&1)
   [[ $ref =~ "Not a git" ]] && return
@@ -39,13 +38,14 @@ function git_prompt_info() {
 }
 
 ## Override the default `git_prompt_status` function
-## This one will try to print a symbol for each change listed in git status.
-## The old version only listed if each type existed or not.
+## Try to print a each change instead of just indicating if each type exists.
+## This gives a better visual sense of how much has changed
 ## Status is computed from the short version of git status that lists out
 ##     xy filename1
 ##     xy filename2
 ## where x and y are statuses such as A (added), M (modified). Details in the
-## git-status manpage
+## git-status manpage.
+## Is this as fast as it gets?
 git_prompt_status() {
   INDEX=$(git status -s 2> /dev/null)
   X_SET=""
@@ -56,29 +56,26 @@ git_prompt_status() {
     Y=$LINE[2]
     [[ $X$Y == '??' ]] && UN_SET="$UN_SET$ZSH_THEME_GIT_PROMPT_UNTRACKED" && continue
     [[ $X$Y == 'UU' ]] && UN_SET="$UN_SET$ZSH_THEME_GIT_PROMPT_UNMERGED" && continue
-    X_SET="$X_SET$X"
-    Y_SET="$Y_SET$Y"
+    [[ $Y == 'M' ]] && Y_SET="$Y_SET$ZSH_THEME_GIT_TREE_MODIFIED"
+    [[ $Y == 'D' ]] && Y_SET="$Y_SET$ZSH_THEME_GIT_TREE_DELETED"
+    [[ $X == 'M' ]] && X_SET="$X_SET$ZSH_THEME_GIT_INDEX_MODIFIED" && continue
+    [[ $X == 'A' ]] && X_SET="$X_SET$ZSH_THEME_GIT_INDEX_ADDED" && continue
+    [[ $X == 'D' ]] && X_SET="$X_SET$ZSH_THEME_GIT_INDEX_DELETED" && continue
+    [[ $X == 'R' ]] && X_SET="$X_SET$ZSH_THEME_GIT_INDEX_RENAMED" && continue
+    [[ $X == 'C' ]] && X_SET="$X_SET$ZSH_THEME_GIT_INDEX_COPIED" && continue
   done
-  X_SET=$(sed "s/[ ]//g" <<< $X_SET)
-  X_SET=$(sed "s/M/$ZSH_THEME_GIT_INDEX_MODIFIED/g" <<< $X_SET)
-  X_SET=$(sed "s/A/$ZSH_THEME_GIT_INDEX_ADDED/g" <<< $X_SET)
-  X_SET=$(sed "s/D/$ZSH_THEME_GIT_INDEX_DELETED/g" <<< $X_SET)
-  X_SET=$(sed "s/R/$ZSH_THEME_GIT_INDEX_RENAMED/g" <<< $X_SET)
-  X_SET=$(sed "s/C/$ZSH_THEME_GIT_INDEX_COPIED/g" <<< $X_SET)
-  Y_SET=$(sed "s/[ ]//g" <<< $Y_SET)
-  Y_SET=$(sed "s/M/$ZSH_THEME_GIT_TREE_MODIFIED/g" <<< $Y_SET)
-  Y_SET=$(sed "s/D/$ZSH_THEME_GIT_TREE_DELETED/g" <<< $Y_SET)
   STATUS="$X_SET$Y_SET$UN_SET"
   echo $STATUS
 }
 
 ## Override the default `current_repository` function
+## Cope with non-ssh repos by not relying on ':'. Instead, we look for the name
+## suffixed with .git
+##
 ## We don't need to test if HEAD is a symbolic ref - that gets controlled in
 ## git_prompt_info(). Unlike `current_branch` there are no oh-my-zsh shortcuts
 ## that will be broken if we don't test for this.
-##
-## also, the built-in function cannot cope with non-ssh repos because it relies
-## on there being a ':' before the repo name
+## Is there another way? 4 pipelines seems excessive
 function current_repository() {
   echo $(git remote -v | head -1 | grep -o '[^/]*\.git' | sed 's/\.git//')
 }